gui/macOS: Avoid retain call on extensionNcAccount by allocing new string
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Wed, 26 Mar 2025 12:44:28 +0000 (13:44 +0100)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Thu, 27 Mar 2025 14:16:05 +0000 (14:16 +0000)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/macOS/fileproviderxpc_mac_utils.mm

index 344031144f060296db7c204d32fd9a0c3398710b..42aefe9a3047a68c47c6cf81f4dd48b4a29e16b1 100644 (file)
@@ -244,8 +244,7 @@ NSString *getExtensionAccountId(NSObject<ClientCommunicationProtocol> *const cli
             dispatch_group_leave(group);
             return;
         }
-        extensionNcAccount = [NSString stringWithString:extensionAccountId];
-        [extensionNcAccount retain];
+        extensionNcAccount = [[NSString alloc] initWithString:extensionAccountId];
         dispatch_group_leave(group);
     }];
     dispatch_group_wait(group, DISPATCH_TIME_FOREVER);